Skip to content

refactor: update component name, match success state response #2466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

siddy2181
Copy link
Contributor

Description

Why are we making these changes? Include references to any related Jira tasks or GitHub Issues

  • The ThreeDS Zoid component does not have any fastlane related logic, so a generic name is more suitable.
  • No breaking change
  • Fixes the response state from success to succeeded to match the integration guide pattern

Reproduction Steps (if applicable)

Screenshots (if applicable)

Dependent Changes (if applicable)

Groups who should review (if applicable)

❤️ Thank you!

@siddy2181 siddy2181 requested a review from a team as a code owner January 28, 2025 23:24
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.18%. Comparing base (08435cd) to head (487dab4).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/three-domain-secure/component.jsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2466      +/-   ##
==========================================
+ Coverage   51.15%   51.18%   +0.03%     
==========================================
  Files         159      159              
  Lines       14901    14845      -56     
  Branches      838      834       -4     
==========================================
- Hits         7623     7599      -24     
+ Misses       7175     7143      -32     
  Partials      103      103              
Flag Coverage Δ
jest 31.29% <ø> (ø)
karma 55.10% <ø> (ø)
vitest 45.63% <85.71%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siddy2181 siddy2181 changed the title update component name, fix success state response refactor: update component name, fix success state response Jan 28, 2025
@siddy2181 siddy2181 changed the title refactor: update component name, fix success state response refactor: update component name, match success state response Jan 28, 2025
Copy link
Contributor

@mchoun mchoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@siddy2181 siddy2181 merged commit 76df556 into main Jan 29, 2025
5 checks passed
@siddy2181 siddy2181 deleted the generic-component-name branch January 29, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants